[PATCH] D102379: scudo: Check for UAF in ring buffer before OOB in more distant blocks.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/combined.h:1325
 
-    if (CheckOOB(Info.BlockBegin))
+    if (MinDistance == 0 && CheckOOB(Info.BlockBegin))
       return;
----------------
eugenis wrote:
> Did you mean
> ```
> if (CheckOOB(Info.BlockBegin) || MinDistance == 0)
> ```
> ?
I think that would result in us not checking the surrounding blocks if `MinDistance == 0`, even if `MaxDistance` was some larger number.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102379/new/

https://reviews.llvm.org/D102379