[PATCH] D102448: Remove (unneeded) '-asan-use-after-return' from hoist-argument-init-insts.ll.

Kevin Athey via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 13 17:54:15 PDT 2021


kda added a comment.

No.
(My planned change won't change this behavior:
https://github.com/google/sanitizers/issues/1394)
I found the existing test misleading.
Changing or removing the flag does not change whether the test passes.

If the test is guarding against something changing when
'-asan-use-after-return=1', then perhaps a comment making that clear would
be useful (or even better explicit code that shows what is being avoided is
NOT present).
I don't have a clear understanding how the two features interaction (UAR
and UAS).  So, this sort of test may need to cover the UAR case.

FYI, I'm new here, and I try to leave the code better (clearer) when
possible.
I'm also okay, with "bug off", just leave it alone.  It is not broken.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102448/new/

https://reviews.llvm.org/D102448



More information about the llvm-commits mailing list