[PATCH] D101681: [Compiler-rt] Distinguish between testing just built runtime libraries and the libraries shipped with the compiler.

[Julian Lettner via Phabricator via llvm-commits]

yln accepted this revision.
yln added inline comments.


================
Comment at: compiler-rt/test/CMakeLists.txt:5
+option(COMPILER_RT_TEST_BUILT_LIBS
+  "When testing use the just built runtime libraries instead of the compiler's. \
+  This option has no effect when the compiler-rt build library directory is  \
----------------
aralisza wrote:
> nit, is there a missing comma here? I had to read this a few times to parse it lol
> 
> ```
> When testing, use the just built runtime libraries instead of the compiler's.
> ```
Maybe name and phrase this as "test with standalone libs"?

I was initially confused what "test (with) built libs" meant.  Usually (standard build), both the compiler and the runtime libs are "just built" and this distinction is only meaningful in the standalone case, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101681/new/

https://reviews.llvm.org/D101681