[PATCH] D101919: RISCV: add a few deprecated aliases for CSRs

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 13 13:53:42 PDT 2021


jrtc27 added a comment.

In D101919#2757958 <https://reviews.llvm.org/D101919#2757958>, @luismarques wrote:

> In D101919#2756343 <https://reviews.llvm.org/D101919#2756343>, @asb wrote:
>
>> I'll put this patch on the agenda for the sync-up call today, but particularly now it emits a warning I'm inclined to think we should accept this in order to provide drop-in compatibility for GNU toolchains.
>
> We discussed this as part of today's LLVM RISC-V community sync-up call. I don't think there objections to merging this support now that it also emits warnings (correct me if I'm misremembering). Personally, I think it's a borderline decision, but I can see the appeal of ensuring drop-in compatibility with the GNU toolchains. Let's give it a few more days to let others chime in, now that this issue has been brought up in the call.

Yeah. At this point I'd personally prefer to keep it an error, backwards compatibility makes less and less sense as time goes on, but I'm not going to object now there are warnings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101919/new/

https://reviews.llvm.org/D101919



More information about the llvm-commits mailing list