[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

~5% object size growth (probably more heavily weighted towards object size when using Split DWARF (most of the growth is likely in the .debug_addr/rela.debug_addr in the .o file, rather than in the DIEs in the .dwo file)) seems like enough that I wouldn't really be super happy about this.

Can we come back to this question that seems like it still hasn't been addressed:

Does anyone have this example (where DW_OP_entry_value is used at -O0)? It'd be great to look at it & see if it's a case of unnecessarily losing the location, or legitimately losing it and using entry_value for best-effort recovery (& then a question of whether the loss is appropriate at -O0, or if we want to pessimize -O0 further to avoid the loss).

(it seems like there's no flang-specific argument here that I've seen - if we are creating DW_OP_entry_value at -O0 then that's a debuggability problem for both Clang and Flang and we should be adopting the same solution here, so unless there's something Flang specific, the "this is harmless to clang and good for flang, so why don't we add the flag" doesn't seem to hold/be relevant here)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99160/new/

https://reviews.llvm.org/D99160