[PATCH] D102179: [Demangle][Rust] Parse integer constants

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Seems good, thanks!



================
Comment at: llvm/lib/Demangle/RustDemangle.cpp:553-555
+// value and stores hex digits in HexDigits. The resulting value might be not
+// representable in uint64_t, so check the length of hex digits (<= 16) before
+// using the returned value.
----------------
Might be worth a more formal description here, something like:
```
The return value is unspecified if HexDigits.size() > 16.
```

(so you can't even rely on the return value being zero, maximum, or some other default value - it's arbitrary/meaningless)



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102179/new/

https://reviews.llvm.org/D102179