[PATCH] D102321: [llvm-nm] Support the -V option, print that the tool is compatible with GNU nm

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Thanks for the reviews!



================
Comment at: llvm/docs/CommandGuide/llvm-nm.rst:235-236
 
  Display the version of the :program:`llvm-nm` executable. Does not stack with
  other commands.
 
----------------
jhenderson wrote:
> Perhaps change the end of the description here to something like "... executable, then exit." The exiting aspect I think deserves describing, since llvm-nm doesn't need any other commands to still do useful work on an object normally.
> 
Ok, amending that.


================
Comment at: llvm/test/tools/llvm-nm/libtool-version.test:1-2
+Check that the output of llvm-nm -V (and --version) contains the text
+"GNU" somewhere, to let libtool know that it is compatible with GNU nm.
+
----------------
jhenderson wrote:
> I know they're not strictly necessary here, but I'd add some comment markers to make the comments stand out from the rest of the test.
Sure, will do


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102321/new/

https://reviews.llvm.org/D102321