[PATCH] D102367: [LowerConstantIntrinsics] reuse isManifestLogic from ConstantFolding
George Burgess IV via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 13 11:41:14 PDT 2021
george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
one drive-by nit and lgtm -- thanks!
================
Comment at: llvm/lib/IR/Constants.cpp:829
+ return true;
+ } else if (isa<ConstantAggregate>(this) || isa<ConstantExpr>(this)) {
+ for (const Value *subc : operand_values()) {
----------------
nit: llvm style prefers no `else`s after `return`s
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102367/new/
https://reviews.llvm.org/D102367
More information about the llvm-commits
mailing list