[PATCH] D102136: [NewPM] Add C bindings for new pass manager

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

looks pretty good, just one nit



================
Comment at: llvm/include/llvm-c/Transforms/PassBuilder.h:45
+                           LLVMPipelineTuningOptionsRef PTO, LLVMModuleRef M,
+                           LLVMBool Debug, LLVMBool VerifyEach,
+                           const char *Passes);
----------------
We should also move `Debug` and `VerifyEach` into their own separate options. We might make changes to these options (as I'm doing right now for `DebugLogging`), so we shouldn't tie down the exact option types into the main `LLVMRunPasses` API.

Maybe instead of `LLVMPipelineTuningOptionsRef`, we just have some generic `LLVMPassBuilderOptionsRef` which includes a PTO and these Debug/VerifyEach bools. That way if we want to change exactly how `Debug` works in the future, we can change the LLVMPassBuilderOptions underlying struct, and we only need to deprecate a separate API, not the main `LLVMRunPasses`. (or whatever naming you'd like)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102136/new/

https://reviews.llvm.org/D102136