[PATCH] D102383: [ELF] Add -Bno-symbolic

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Driver.cpp:956-962
+  if (opt::Arg *arg = args.getLastArg(OPT_Bno_symbolic, OPT_Bsymbolic_functions,
+                                      OPT_Bsymbolic)) {
+    if (arg->getOption().matches(OPT_Bsymbolic_functions))
+      config->bsymbolicFunctions = true;
+    else if (arg->getOption().matches(OPT_Bsymbolic))
+      config->bsymbolic = true;
+  }
----------------
jhenderson wrote:
> If I'm reading this change correctly, there is a change in behaviour for the case where both `-Bsymbolic` and `-Bsymbolic-functions` are specified. Previously, both config variables would be set and since `-Bsymbolic-functions` is a subset of `-Bsymbolic`, it would behave the same as `-Bsymbolic`. Now, if the arguments were ordered `-Bsymbolic -Bsymbolic-functions`, only the `config->bsymbolicFunctions` variable would be set, and consequently we'd see a behaviour change.
> 
> Is this intentional? It's fine, if that's what GNU does, but it probably deserves a release note.
Yes. Added


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102383/new/

https://reviews.llvm.org/D102383