[PATCH] D102353: [AArch64] Lower fpto*i.sat intrinsics.

Thu May 13 07:00:43 PDT 2021

SjoerdMeijer added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.h:960
   SDValue LowerFP_TO_INT(SDValue Op, SelectionDAG &DAG) const;
+  SDValue LowerFP_TO_INT_SAT(SDValue Op, SelectionDAG &DAG) const;
   SDValue LowerINT_TO_FP(SDValue Op, SelectionDAG &DAG) const;
----------------
jbramley wrote:
> Can I just ignore these? Matching the de-facto convention seems appropriate, but I think these are responsible for the reported build failure.
Yep, this is an unhelpful message in this case; this is just following the convention/style in this file so is alright.
I had a quick look, but am not sure what the cause of the failure is as it seems all regression tests are passing, but somewhere it is doing an Exit 1. I would ignore this and blame it on a glitch or flaky bot. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102353/new/

https://reviews.llvm.org/D102353