[PATCH] D102231: [AMDGPU][AsmParser/Disassembler] Correct A16 and G16 handling

[David Stuttard via Phabricator via llvm-commits]

dstuttard marked an inline comment as done.
dstuttard added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.image.sample.a16.dim.ll:4
 ; RUN: llc -march=amdgcn -mcpu=gfx1010 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX10 %s
+; This test is expected to fail until the new a16/g16 codegen changes are in place
+; XFAIL: *
----------------
dp wrote:
> I may be mistaken but this comment hints that you are going to submit this patch independently of
> https://reviews.llvm.org/D102066. This won't work because many tests you added in the last update will fail - they depend on changes in MIMG_Sampler_AddrSizes. (Maybe there are more dependencies - I did not dig deeper.)
> 
You are correct.
I've moved the change into this patch.

I've checked them independently this time and they both pass lit testing.

Not sure that trying to keep these as two patches was worthwhile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102231/new/

https://reviews.llvm.org/D102231