[PATCH] D100167: [AIX] Adjust CSR order to avoid breaking ABI regarding traceback

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added a comment.

Please add some info about how this affects functions that need the frame pointer. Do we get more/less saves/restores? Does something go wrong?



================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.td:294
   let AltOrderSelect = [{
-    return MF.getSubtarget<PPCSubtarget>().is64BitELFABI();
+    if (MF.getSubtarget<PPCSubtarget>().is64BitELFABI())
+      return 1;
----------------
jsji wrote:
> Please make this a Subtarget function, something like `PPCSubtarget::getGPRAllocationOrder`, so that we don't need to duplicate code here.
The name should indicate that it is the index into the list of allocation orders. So maybe `PPCSubtarget::getGPRAllocationOrderIdx()`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100167/new/

https://reviews.llvm.org/D100167