[PATCH] D100751: [VPlan] Properly handle sinking of replicate regions.

Thu May 13 05:52:02 PDT 2021

ebrevnov added inline comments.

================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9126
+    auto *SplitBlock =
+        Target->getParent()->splitAt(std::next(Target->getIterator()));
+
----------------
fhahn wrote:
> fhahn wrote:
> > ebrevnov wrote:
> > > Hi Florian,
> > > 
> > > Just want to give you a heads up that we observe crash downstream at this line. In particular, std::next(Target->getIterator()) returns null. So far I have internal reproducer only. Maybe you can figure out the problem faster than I come  up with upstreamable reproducer. Thanks in advance.
> > Thanks for the heads-up! I'll try to see if I can come up with a test case tomorrow.
> I managed to construct a test case that requires splitting at the end of the block, which crashes at the moment, because the `assert` dereferences splitAt unconditionally. Should be fixed in bdada7546e6b
> 
> Please let me know if there's still an issue downstream.
Thanks for quick turn around. Will check and let you know.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100751/new/

https://reviews.llvm.org/D100751