[PATCH] D99080: Normalize usage of StrBoolAttr

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D99080#2756453 <https://reviews.llvm.org/D99080#2756453>, @nikic wrote:

> In D99080#2724930 <https://reviews.llvm.org/D99080#2724930>, @serge-sans-paille wrote:
>
>> In D99080#2723694 <https://reviews.llvm.org/D99080#2723694>, @nikic wrote:
>>
>>> Should this one be abandoned now?
>>
>> It depends. I'd like it to land, but that means changing the behavior of
>>
>>   --enable-no-infs-fp-math                                              - Enable FP math optimizations that assume no +-Infs
>>   --enable-no-nans-fp-math                                              - Enable FP math optimizations that assume no NaNs
>>   --enable-no-signed-zeros-fp-math                                      - Enable FP math optimizations that assume the sign of 0 is insignificant
>>   --enable-no-trapping-fp-math                                          - Enable setting the FP exceptions build attribute not to use exceptions
>>   --enable-unsafe-fp-math                                               - Enable optimizations that may decrease FP precision
>>
>> from `lli`. Maybe I should post a small RFC on that topic ?
>
> It would be ideal to drop these llc flags completely, and adjust the tests that use them to use FMF flags. I don't think they serve any purpose apart from making bad tests simpler to write.

Agree. IIUC, we can do that part now without waiting for the next question to be resolved...

> @spatel Are there any nearer-term plans to drop support for global fast math attributes/flags?

We haven't made much progress lately. I think we need to propagate FMF on FP values more thoroughly -- function arguments, casts, and possibly memory ops (not sure how that reconciles with type-less memory) -- to guarantee that FMF is a complete replacement for the global flags in IR ( https://llvm.org/PR35607 ). But it's also possible that the backend is already good enough now that we can try it there (but it's a job that requires updating lots of codegen tests last time I checked).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99080/new/

https://reviews.llvm.org/D99080