[PATCH] D102231: [AMDGPU][AsmParser/Disassembler] Correct A16 and G16 handling

Thu May 13 04:22:12 PDT 2021

dp added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.image.sample.a16.dim.ll:4
 ; RUN: llc -march=amdgcn -mcpu=gfx1010 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX10 %s
+; This test is expected to fail until the new a16/g16 codegen changes are in place
+; XFAIL: *
----------------
I may be mistaken but this comment hints that you are going to submit this patch independently of
https://reviews.llvm.org/D102066. This won't work because many tests you added in the last update will fail - they depend on changes in MIMG_Sampler_AddrSizes. (Maybe there are more dependencies - I did not dig deeper.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102231/new/

https://reviews.llvm.org/D102231