[PATCH] D102316: [symbolizer] Added StartAddress for the resolved function.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

This seems like a reasonable idea in principle to me, and the code as-is looks good for JSON output. I feel like it shouldn't be limited to just that output format however. I'm uncertain how to represent this in other output formats, but it may want to be through a new llvm-symbolizer option (e.g. `--print-start-address`), or maybe even it could just be part of the verbose output (since that is where the `StartLine` output is printed. What do you think?



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1067-1069
+  if (auto LowPcAddr = toSectionedAddress(DIE.find(DW_AT_low_pc))) {
+    StartAddress = LowPcAddr->Address;
+  }
----------------
No need for braces for single-line if statements.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102316/new/

https://reviews.llvm.org/D102316