[PATCH] D101817: [MC][X86] Automatic alignment for Macro-Op Fusion

[Kan Shengchen via Phabricator via llvm-commits]

skan added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:188
+      // Required AlignBranch kinds for macro-fusion alignment
+      AlignBranchType.clear();
+      AlignBranchType.addKind(X86::AlignBranchFused);
----------------
Why do you clear the branch type here?


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:189-190
+      AlignBranchType.clear();
+      AlignBranchType.addKind(X86::AlignBranchFused);
+      AlignBranchType.addKind(X86::AlignBranchJcc);
+    }
----------------
We need test to make sure unfused jcc is not aligned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101817/new/

https://reviews.llvm.org/D101817