[PATCH] D99354: [SimpleLoopUnswitch] Port partially invariant unswitch from LoopUnswitch to SimpleLoopUnswitch

Thu May 13 00:21:43 PDT 2021

jaykang10 added a comment.

In D99354#2754816 <https://reviews.llvm.org/D99354#2754816>, @fhahn wrote:

> In D99354#2754454 <https://reviews.llvm.org/D99354#2754454>, @jaykang10 wrote:
>
>> In D99354#2754363 <https://reviews.llvm.org/D99354#2754363>, @fhahn wrote:
>>
>>> In D99354#2750822 <https://reviews.llvm.org/D99354#2750822>, @jaykang10 wrote:
>>>
>>>> In D99354#2750756 <https://reviews.llvm.org/D99354#2750756>, @fhahn wrote:
>>>>
>>>>> I think this causes https://bugs.llvm.org/show_bug.cgi?id=50279 as well
>>>>
>>>> @fhahn Thanks for letting me know. Let me have a look.
>>>
>>> Thanks. If it's not straight-forward to resolve, it would be best to revert the patch for now.
>>
>> @fhahn Thanks for kind suggestion. I have figured out what causes the endless compiling. It looks we need to move partially invariant instructions rather than duplicating them. Once I resolve this issue, I need to check the score of benchmarks again. Therefore, I would post a patch for review tomorrow or the day after tomorrow.
>
> Great, thanks! It sounds like it would make sense to revert until this is resolved than, so there's no need to rush :)

Yep, I will revert it now. Additionally, I have seen SimpleLoopUnswitch with this patch does not affect performance number of omnetpp in SPEC2017. I need to figure out it too. Once I fixed these issues, I will let you know.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99354/new/

https://reviews.llvm.org/D99354