[PATCH] D102155: [AIX][compiler-rt] Build and install standalone libatomic

[Kai Luo via Phabricator via llvm-commits]

lkail added inline comments.


================
Comment at: compiler-rt/cmake/Modules/CompilerRTAIXUtils.cmake:62
+     -Wl,-bnoentry -Wl,-bexport:${export_list} \
+     -Wl,-bmodtype:SRE -Wl,-lc" PARENT_SCOPE)
+endfunction()
----------------
daltenty wrote:
> nit: don't some of these duplicate the driver default link flags for building a shared library?
I've checked generated `build.ninja`
```
  LANGUAGE_COMPILE_FLAGS = -O3 -DNDEBUG
  LINK_FLAGS = -Wl,-brtl   -m64 -Wl,-H512 -Wl,-D0      -Wl,-T512 -Wl,-bhalt:4 -Wl,-bernotok      -Wl,-bnoentry -Wl,-bexport:/home/lkail/llvm/dev/llvm-project/compiler-rt/lib/builtins/atomic.exp      -Wl,-bmodtype:SRE -Wl,-lc
  LINK_LIBRARIES = -Wl,-blibpath:/usr/lib:/lib
  OBJECT_DIR = lib/builtins/CMakeFiles/clang_rt.atomic-dynamic-powerpc64.dir
  POST_BUILD = :
  PRE_LINK = :
```
Looks no duplicated item in flags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102155/new/

https://reviews.llvm.org/D102155