[PATCH] D102220: [NFC, CFI] Use unsigned type for CFI register values in parser/streamer code

Venkata Ramanaiah Nalamothu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 12 18:58:44 PDT 2021


RamNalamothu added a comment.

In D102220#2755545 <https://reviews.llvm.org/D102220#2755545>, @MaskRay wrote:

>> the interfacing code in parsers and streamers are using both signed and unsigned type in different parts.
>
> Where is uint64_t used? Most places use int64_t.

For instance in `AsmParser::parseRegisterOrRegisterNumber()` and type cast in `MCStreamer::emitCFIDefCfaRegister()`.

Anyway, I have changed the summary as the above scenarios are minor in the entire changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102220/new/

https://reviews.llvm.org/D102220



More information about the llvm-commits mailing list