[PATCH] D102367: [Intrinsics] is_constant intrinsic on undef evaluates to false

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/EarlyCSE.cpp:1247-1251
+    // Skip is constant intrinsics.
+    if (match(&Inst, m_Intrinsic<Intrinsic::is_constant>())) {
+      LLVM_DEBUG(dbgs() << "EarlyCSE skipping is.constant: " << Inst << '\n');
+      continue;
+    }
----------------
ah, this can be dropped now; it looks like early-cse and instcombine reuse the same constant folding logic, so only that needs updating to fix this for either pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102367/new/

https://reviews.llvm.org/D102367