[PATCH] D101045: [IR][Verifier] Targets can specify multiple alloca address spaces

Wed May 12 16:15:15 PDT 2021

arsenm added a comment.

In D101045#2718774 <https://reviews.llvm.org/D101045#2718774>, @wingo wrote:

> In D101045#2711957 <https://reviews.llvm.org/D101045#2711957>, @arsenm wrote:
>
>> It hadn't occurred to me to add a field to the datalayout purely for the verifier. That seems a bit strange, since it's not exactly a target property.
>
> Yeah understood.  If we want some targets to have the check and some to not have the check, do you know of a better place to express this?  I thought the same place that the target's alloca address space is defined might not be unreasonable, but I am new here :)

I think we should have target specific IR verifiers, not pollute the datalayout. There are a number of other places such a verifier would be useful

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101045/new/

https://reviews.llvm.org/D101045