[PATCH] D102377: [AIX] Do NOT emit avaiable externally symbols
Jinsong Ji via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 12 16:08:00 PDT 2021
jsji created this revision.
jsji added reviewers: PowerPC, Xiangling_L, DiggerLin, sfertile.
Herald added subscribers: kbarton, hiraditya, nemanjai.
jsji requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Globals with “available_externally” linkage are never emitted into the
object file corresponding to the LLVM module.
This is to fix the LIT failure in CodeGen/Generic/externally_available.ll
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D102377
Files:
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
Index: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
===================================================================
--- llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
+++ llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
@@ -1803,8 +1803,6 @@
LinkageAttr = MCSA_Weak;
break;
case GlobalValue::AvailableExternallyLinkage:
- LinkageAttr = MCSA_Extern;
- break;
case GlobalValue::PrivateLinkage:
return;
case GlobalValue::InternalLinkage:
@@ -2149,6 +2147,10 @@
}
void PPCAIXAsmPrinter::emitGlobalVariable(const GlobalVariable *GV) {
+ // Should not emit 'available externally' functions at all
+ if (GV->hasAvailableExternallyLinkage())
+ return;
+
// Special LLVM global arrays have been handled at the initialization.
if (isSpecialLLVMGlobalArrayToSkip(GV) || isSpecialLLVMGlobalArrayForStaticInit(GV))
return;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102377.344980.patch
Type: text/x-patch
Size: 849 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210512/3181ff35/attachment.bin>
More information about the llvm-commits
mailing list