[PATCH] D102334: [AMDGPU] Sort LDS globals based on thier size and alignment.

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 12 11:25:17 PDT 2021


rampitec added a comment.

In D102334#2754646 <https://reviews.llvm.org/D102334#2754646>, @JonChesterfield wrote:

> This seems to put all variables into one struct. I was suggesting a struct type and instance per kernel, populated by the subset of variables that can be accessed by kernel and functions called by it. Strictly speaking this does do that, but the subset can usually be smaller than the set of all variables in the module.

Right, I think we need a minimal (or as small as we can if not minimal) set per kernel.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102334/new/

https://reviews.llvm.org/D102334



More information about the llvm-commits mailing list