[PATCH] D102219: Optimize GSymCreator::finalize.

[Greg Clayton via Phabricator via llvm-commits]

clayborg added a comment.

In D102219#2753742 <https://reviews.llvm.org/D102219#2753742>, @simon.giesecke wrote:

> In D102219#2752199 <https://reviews.llvm.org/D102219#2752199>, @clayborg wrote:
>
>> There are unit tests that could be added if you would like to test a bad case, but existing unit tests should still pass with this.
>
> I had a look at the test cases in llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp. The TestDWARF* test cases seem to provide a template for such a test, but unfortunately I am not familiar with the details of DWARF to come up with a representative test case. With some advice, I could do that in another patch?

No worries. We have existing tests that catch this. But just to clarify, you ran llvm-gsymutil on a GCC binary that caused a major slowdown. It would be great if you could verify that if you run llvm-gsymutil with "--num-threads=1" using the current llvm-gsymutil and with the modified llvm-gsymutil, can you verify that they binaries match? If they don't then we do need to add a test. You have to run with --num-threads=1 to make sure threading doesn't make things change in the final GSYM. So if you can run this test for me and verify things match up, then I will commit this diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102219/new/

https://reviews.llvm.org/D102219