[PATCH] D101972: For visibility of llvm::Any to external

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/include/llvm/ADT/Any.h:116
 
-template <typename T> bool any_isa(const Any &Value) {
+template <typename T> LLVM_EXTERNAL_VISIBILITY bool any_isa(const Any &Value) {
   if (!Value.Storage)
----------------
Sorry for the back and forth, but if it is necessary to mark any_isa with default visibility, then I would prefer your original patch of putting it on the class.

However, I think it should only be necessary to give `TypeId<T>::Id` default visibility. It shouldn't matter which copy of `any_isa` or `id()` gets called, they will all take the address of the same unique `Id` global.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101972/new/

https://reviews.llvm.org/D101972