[PATCH] D102321: [llvm-nm] Support the -V option, print that the tool is compatible with GNU nm

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:2241
+static void printExtraVersionInfo(raw_ostream &outs) {
+  outs << "llvm-nm, compatible with GNU nm\n";
+}
----------------
mstorsjo wrote:
> MaskRay wrote:
> > MaskRay wrote:
> > > Does libtool detect the substring `GNU nm`? If not, the notice should be dropped.
> > > 
> > > For example, `ld.lld` prints `compatible with GNU linkers` just because libtool detects `GNU` (D31199).
> > If yes, there needs to be a comment.
> Libtool detects ”GNU” only, but not necessarily “GNU nm”. Is this wording ok (while adding a comment explaining why) or do you want it written differently?
`"llvm-nm, compatible with GNU nm\n"` is ok, we just need to document the fact.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102321/new/

https://reviews.llvm.org/D102321