[PATCH] D102321: [llvm-nm] Support the -V option, print that the tool is compatible with GNU nm

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 12 09:53:12 PDT 2021


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:2241
+static void printExtraVersionInfo(raw_ostream &outs) {
+  outs << "llvm-nm, compatible with GNU nm\n";
+}
----------------
MaskRay wrote:
> Does libtool detect the substring `GNU nm`? If not, the notice should be dropped.
> 
> For example, `ld.lld` prints `compatible with GNU linkers` just because libtool detects `GNU` (D31199).
If yes, there needs to be a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102321/new/

https://reviews.llvm.org/D102321



More information about the llvm-commits mailing list