[PATCH] D100818: [lld-macho] Implement branch-range-extension thunks

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

lgtm, thanks!



================
Comment at: lld/MachO/MergedOutputSection.cpp:52
+//     chained. Although thunks need not be chained, a program might need
+//     multiple thunks to the same destiation distributed throughout a large
+//     program so that all call sites can have one within range.
----------------



================
Comment at: lld/MachO/MergedOutputSection.cpp:57
+// and use thunks for destinations at greater distance. For now, we only
+// implement thunks. TODO: Adding suppport for branch islands!
+//
----------------



================
Comment at: lld/MachO/MergedOutputSection.cpp:152
+
+// When __stubs is placed after __text (the default), we must estimate the
+// address beyond which stubs are within range of a simple forward branch.
----------------
"Since `__stubs` is placed after __text"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100818/new/

https://reviews.llvm.org/D100818