[PATCH] D102155: [AIX][compiler-rt] Build and install standalone libatomic

[Jinsong Ji via Phabricator via llvm-commits]

jsji added a comment.

Looks mostly good to me as long as you address David's comments.



================
Comment at: compiler-rt/cmake/Modules/CompilerRTAIXUtils.cmake:54
+       OUTPUT ${export_list}
+       CONTENT ${AIX_LIBATOMIC_EXPORTED_ROUTINES_TEXT})
+endfunction()
----------------
daltenty wrote:
> Why not just store this as an `.exp` file in the source tree if we are just going to write it out?  (That would similar to what's in libcxx I believe)
Yes, agree. 


================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:769
+    else()
+      set(${BUILTIN_LINK_FLAGS} ${AIX_LIBATOMIC_LINK_FLAGS})
+    endif()
----------------
This should be platform independent? So that people can override libatomic link flags to be different than builtin link flags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102155/new/

https://reviews.llvm.org/D102155