[PATCH] D102299: [llvm-cov][test] Add test coverage for "gcov" implying "llvm-cov gcov" compatibility.
Jordan Rupprecht via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 12 08:21:17 PDT 2021
rupprecht added a comment.
In D102299#2753300 <https://reviews.llvm.org/D102299#2753300>, @jhenderson wrote:
> Is it strictly ends with, or do things like file extensions, version numbers etc have an impact? See the additional test cases in https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/llvm-objcopy/tool-name.test.
Strictly ends with. See https://github.com/llvm/llvm-project/blob/98575708da9544ccab8939fece9c3d638a32f09f/llvm/tools/llvm-cov/llvm-cov.cpp#L63.
I could land this as-is and copy that from llvm-objcopy so "llvm-gcov-10" would be recognized. Although I don't know how many people are relying on this -- the existence of this doesn't even seem to be in cmake configs (i.e. we don't produce `*gcov` symlinks like we do for llvm-strip).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102299/new/
https://reviews.llvm.org/D102299
More information about the llvm-commits
mailing list