[llvm] 4b98199 - [Passes] Reenable the relative lookup table converter pass for ELF and COFF on aarch64

[Martin Storsjö via llvm-commits]

Author: Martin Storsjö
Date: 2021-05-12T16:42:11+03:00
New Revision: 4b98199ce8fb94d0de46e04b4d7b3a699691d2e1

URL: https://github.com/llvm/llvm-project/commit/4b98199ce8fb94d0de46e04b4d7b3a699691d2e1
DIFF: https://github.com/llvm/llvm-project/commit/4b98199ce8fb94d0de46e04b4d7b3a699691d2e1.diff

LOG: [Passes] Reenable the relative lookup table converter pass for ELF and COFF on aarch64

The bug (PR50227, affecting COFF) that caused the revert in
6f5670a4c3d8c079d4b676140ee69e5cc235d5a8 has been fixed in
382c505d9cfca8adaec47aea2da7bbcbc00fc05c now, so it should be safe
to reenable the pass for that target (and ELF).

In PR50227 it's also mentioned that the same pass seems to cause
problems on aarch64 on darwin, so leaving it disabled there for now.

Added: 
    

Modified: 
    llvm/include/llvm/CodeGen/BasicTTIImpl.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/CodeGen/BasicTTIImpl.h b/llvm/include/llvm/CodeGen/BasicTTIImpl.h
index c03d589e888f..6dc82a87a43a 100644
--- a/llvm/include/llvm/CodeGen/BasicTTIImpl.h
+++ b/llvm/include/llvm/CodeGen/BasicTTIImpl.h
@@ -450,9 +450,9 @@ class BasicTTIImplBase : public TargetTransformInfoImplCRTPBase<T> {
     if (!TargetTriple.isArch64Bit())
       return false;
 
-    // TODO: Triggers an issue in aarch64, so temporarily disable it.
-    // See https://reviews.llvm.org/D99572 for more information.
-    if (TargetTriple.getArch() == Triple::aarch64)
+    // TODO: Triggers issues on aarch64 on darwin, so temporarily disable it
+    // there.
+    if (TargetTriple.getArch() == Triple::aarch64 && TargetTriple.isOSDarwin())
       return false;
 
     return true;