[PATCH] D102219: Optimize GSymCreator::finalize.

[Simon Giesecke via Phabricator via llvm-commits]

simon.giesecke added a comment.

In D102219#2752199 <https://reviews.llvm.org/D102219#2752199>, @clayborg wrote:

> There are unit tests that could be added if you would like to test a bad case, but existing unit tests should still pass with this.

I had a look at the test cases in llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp. The TestDWARF* test cases seem to provide a template for such a test, but unfortunately I am not familiar with the details of DWARF to come up with a representative test case. With some advice, I could do that in another patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102219/new/

https://reviews.llvm.org/D102219