[PATCH] D102312: [llvm-dwp] Skip type unit debug info sections

[Kim-Anh Tran via Phabricator via llvm-commits]

kimanh created this revision.
kimanh updated this revision to Diff 344694.
kimanh added a comment.
kimanh updated this revision to Diff 344695.
kimanh updated this revision to Diff 344696.
kimanh updated this revision to Diff 344701.
kimanh edited the summary of this revision.
kimanh updated this revision to Diff 344759.
kimanh updated this revision to Diff 344761.
kimanh added a reviewer: dblaikie.
kimanh added a subscriber: pfaffe.
kimanh published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Upload whole range of commits.


kimanh added a comment.

Another try uploading whole range.


kimanh added a comment.

.


kimanh added a comment.

adapt comment


kimanh added a comment.

Minor: add comment to unit type.


kimanh added a comment.

Minor: another comment.


kimanh added a comment.

Hello Dave,

I'm splitting up the CL in https://reviews.llvm.org/D101818 into a chain of 3 CLs, this is the first one. I'll add more info on the original comment that you made, ptal!


This patch makes llvm-dwp skip debug info sections that may not be encoding a compile unit.
In DWARF5, debug info sections are also used for type units. As in preparation to support type units,
make llvm-dwp aware of other uses of debug info sections but skip them for now.

The patch first records all .debug_info sections, then goes through them one by one and records
the cu debug info section for writing the index unit, and copies that section to the final dwp output
info section. If it's not a compile unit, skip.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102312

Files:
  llvm/test/tools/llvm-dwp/X86/cu_and_tu_info_section_v5.s
  llvm/test/tools/llvm-dwp/X86/no_cu_found.s
  llvm/test/tools/llvm-dwp/X86/wrong-unit-type-info-v4.s
  llvm/test/tools/llvm-dwp/X86/wrong-unit-type-info-v5.s
  llvm/tools/llvm-dwp/llvm-dwp.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102312.344761.patch
Type: text/x-patch
Size: 17992 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210512/02b01bd6/attachment.bin>