[PATCH] D98714: [SLP] Add insertelement instructions to vectorizable tree

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 12 03:48:22 PDT 2021


ABataev accepted this revision.
ABataev added a comment.

Looks good with a nit



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3819
+      unsigned const Offset = *getInsertIndex(VL[0], 0);
+      if (Offset % NumScalars)
+        Cost += TTI->getShuffleCost(
----------------
I think need to check that `NumElts != NumScalars`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98714/new/

https://reviews.llvm.org/D98714



More information about the llvm-commits mailing list