[PATCH] D101177: [AMDGPU] Skip invariant loads when avoiding WAR conflicts

Piotr Sobczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 12 01:22:37 PDT 2021


piotr updated this revision to Diff 344710.
piotr added a comment.

Added the assert. The assert seems in order here - no hits in the lit tests or Vulkan CTS. There would have been hits in 194 lit tests if the assert had been placed here without the isInvariant check, which somewhat proves usefulness of the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101177/new/

https://reviews.llvm.org/D101177

Files:
  llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
  llvm/test/CodeGen/AMDGPU/mul24-pass-ordering.ll
  llvm/test/CodeGen/AMDGPU/stack-realign.ll
  llvm/test/CodeGen/AMDGPU/waitcnt-no-redundant.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101177.344710.patch
Type: text/x-patch
Size: 7356 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210512/bac6ca04/attachment.bin>


More information about the llvm-commits mailing list