[PATCH] D93470: [VP] Binary floating-point intrinsics.

[Simon Moll via Phabricator via llvm-commits]

simoll marked 2 inline comments as done.
simoll added inline comments.


================
Comment at: llvm/unittests/IR/VPIntrinsicTest.cpp:41
                                       "ashr", "lshr", "shl"};
     std::stringstream Str;
     for (const char *BinaryIntOpcode : BinaryIntOpcodes)
----------------
This is why we need the `sstream` include.


================
Comment at: llvm/unittests/IR/VPIntrinsicTest.cpp:83
   for (const auto &VPDecl : *M) {
     ASSERT_TRUE(VPDecl.isIntrinsic());
     ASSERT_TRUE(VPIntrinsic::IsVPIntrinsic(VPDecl.getIntrinsicID()));
----------------
This assertion is redundantly checked in the `GetParamPos` test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93470/new/

https://reviews.llvm.org/D93470