[PATCH] D102155: [AIX][compiler-rt] Build and install standalone libatomic

[Kai Luo via Phabricator via llvm-commits]

lkail marked 2 inline comments as done.
lkail added inline comments.


================
Comment at: compiler-rt/cmake/Modules/CompilerRTAIXUtils.cmake:3
+
+set(AIX_LIBATOMIC_EXPORTED_ROUTINES
+  __atomic_compare_exchange
----------------
jsji wrote:
> Can we make *ALL* the code in this file platform independent?  Although there are NO other users in other platform, we can make it reusable in case there are similar requests from other platform.
> 
> So, please remove `AIX_` prefix here. 
I assume only AIX's binder need these exported symbols, so I make them AIX specific.


================
Comment at: compiler-rt/cmake/Modules/CompilerRTAIXUtils.cmake:61
+                        POSITION_INDEPENDENT_CODE OFF
+                        COMPILE_FLAGS -m${bitmode} -I -qmakedep=gcc
+                        LINK_FLAGS "-Wl,-b${bitmode} -Wl,-H512 -Wl,-D0 \
----------------
jsji wrote:
> Can we pass the flag into this functions instead of hardcoding them here.
I leave these flags as default options, we can use `-DAIX_LIBATOMIC_LINK_FLAGS` to change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102155/new/

https://reviews.llvm.org/D102155