[PATCH] D102258: Fixed llvm-objcopy to add correct symbol table for ELF with program headers.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 12 00:43:24 PDT 2021


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with nit.



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/add-symbol-no-symtab.test:109
+
+## Check the created .symtab is correct in case of existing ProgramHeaders.
+# RUN: yaml2obj --docnum=4 %s -o %t4
----------------
The name `ProgramHeaders` (i.e. with that specific spelling) is specific to the YAML, but the actual issue is to do with program headers in general in the object.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102258/new/

https://reviews.llvm.org/D102258



More information about the llvm-commits mailing list