[PATCH] D101972: For visibility of llvm::Any to external

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 11 21:14:35 PDT 2021


tstellar added a comment.

FWIW,  I was originally against adding LLVM_EXTERNAL_VISIBILITY to the class, because I thought it was just working around a fundamental flaw in -fvisiblity=hidden, but based on the discussion here, I've fine with the proposed solution.



================
Comment at: llvm/include/llvm/ADT/Any.h:26
 
-class Any {
+class LLVM_EXTERNAL_VISIBILITY Any {
   template <typename T> struct TypeId { static const char Id; };
----------------
Can you add a comment explaining why we need this here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101972/new/

https://reviews.llvm.org/D101972



More information about the llvm-commits mailing list