[PATCH] D102145: [Coroutines] Add `llvm.coro.align` and `llvm.coro.raw.frame.ptr.offset` intrinsics

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 11 16:57:11 PDT 2021


ychen added a comment.

In D102145#2747094 <https://reviews.llvm.org/D102145#2747094>, @ChuanqiXu wrote:

> The overall patch looks good to me. It seems like this patch did nothing without D97915 <https://reviews.llvm.org/D97915>. And it is different from normal NFC changes. I am not sure if it is more proper to merge this with D97915 <https://reviews.llvm.org/D97915>.

It could be merged with D97915 <https://reviews.llvm.org/D97915>. I was afraid the patch size would be too big to make reviewing inconvenient. I'll add a standalone test for added intrinsics to make the patch self-ccontain.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102145/new/

https://reviews.llvm.org/D102145



More information about the llvm-commits mailing list