[PATCH] D101780: [CoverageMapping] Handle gaps in counter IDs for source-based coverage

Rich Kadel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 11 14:47:35 PDT 2021


richkadel added a comment.

> Do we need counters on edges if we're only interested in line segment coverage?

Edge counters exist so they can be operands in expressions, and since they don't have a code region, they would not be referenced directly by a code region in a report; but the expression might, and that's we we need them.

(I don't think "line coverage" is a factor. The coverage map only concerns itself with the regions. If the region happens to have one or more newlines, or if there are multiple regions on a line, that isn't relevant to the coverage map; at least not for Rust. `llvm-cov` computes line coverages when generating the report.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101780/new/

https://reviews.llvm.org/D101780



More information about the llvm-commits mailing list