[PATCH] D101305: [LoopInterchange] Fix legality for triangular loops
Congzhe Cao via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 11 14:42:22 PDT 2021
congzhe reopened this revision.
congzhe added a comment.
This revision is now accepted and ready to land.
In D101305#2752100 <https://reviews.llvm.org/D101305#2752100>, @fhahn wrote:
> In D101305#2752096 <https://reviews.llvm.org/D101305#2752096>, @leonardchan wrote:
>
>> Looks like this patch might be leading to the test failure we're seeing on our two-stage-builders (https://luci-milo.appspot.com/p/fuchsia/builders/prod/clang-linux-x64/b8847508232983084096):
>>
>> FAIL: LLVM :: Transforms/LoopInterchange/inner-indvar-depend-on-outer-indvar.ll (31462 of 43640)
>> ******************** TEST 'LLVM :: Transforms/LoopInterchange/inner-indvar-depend-on-outer-indvar.ll' FAILED ********************
>> Script:
>> --
>> : 'RUN: at line 1'; /b/s/w/ir/x/w/staging/llvm_build/tools/clang/stage2-bins/bin/opt < /b/s/w/ir/x/w/llvm-project/llvm/test/Transforms/LoopInterchange/inner-indvar-depend-on-outer-indvar.ll -basic-aa -loop-interchange -verify-dom-info -verify-loop-info -S -debug 2>&1 | /b/s/w/ir/x/w/staging/llvm_build/tools/clang/stage2-bins/bin/FileCheck /b/s/w/ir/x/w/llvm-project/llvm/test/Transforms/LoopInterchange/inner-indvar-depend-on-outer-indvar.ll
>> --
>> Exit Code: 1
>>
>> Command Output (stderr):
>> --
>> /b/s/w/ir/x/w/llvm-project/llvm/test/Transforms/LoopInterchange/inner-indvar-depend-on-outer-indvar.ll:14:10: error: CHECK: expected string not found in input
>> ; CHECK: Loop structure not understood by pass
>> ^
>> <stdin>:1:1: note: scanning from here
>> opt: Unknown command line argument '-debug'. Try: '/b/s/w/ir/x/w/staging/llvm_build/tools/clang/stage2-bins/bin/opt --help'
>> ^
>> <stdin>:1:19: note: possible intended match here
>> opt: Unknown command line argument '-debug'. Try: '/b/s/w/ir/x/w/staging/llvm_build/tools/clang/stage2-bins/bin/opt --help'
>> ^
>>
>> Input file: <stdin>
>> Check file: /b/s/w/ir/x/w/llvm-project/llvm/test/Transforms/LoopInterchange/inner-indvar-depend-on-outer-indvar.ll
>>
>> -dump-input=help explains the following input dump.
>>
>> Input was:
>> <<<<<<
>> 1: opt: Unknown command line argument '-debug'. Try: '/b/s/w/ir/x/w/staging/llvm_build/tools/clang/stage2-bins/bin/opt --help'
>> check:14'0 X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
>> check:14'1 ? possible intended match
>> 2: opt: Did you mean '--debugify'?
>> check:14'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> >>>>>>
>>
>> --
>>
>> ********************
>> Testing: 0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
>> ********************
>> Failed Tests (1):
>> LLVM :: Transforms/LoopInterchange/inner-indvar-depend-on-outer-indvar.ll
>>
>>
>> Testing Time: 47.05s
>> Unsupported : 11360
>> Passed : 32216
>> Expectedly Failed: 63
>> Failed : 1
>>
>> Is this a known issue?
>
> Sounds like this test needs to either require an assert build or not use `-debug` (or using remarks instead)
Thanks for pointing it out. I guess I'll revert this patch and re-commit after I add `; REQUIRES: asserts` or use remarks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101305/new/
https://reviews.llvm.org/D101305
More information about the llvm-commits
mailing list