[PATCH] D96883: Add support for JSON output style to llvm-symbolizer

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h:40
   DIPrinter(){};
   virtual ~DIPrinter(){};
 
----------------
MaskRay wrote:
> `virtual ~DIPrinter(){};` => `virtual ~DIPrinter() {}`
> 
> Does clang-format complain on `virtual ~DIPrinter(){};` ?
clang-format doesn't have warnings/errors really - it does it's best to guess at what's going on and format it.

The extra ';' confuse clang-format and so it formats poorly.

@jhenderson also asked @aorlov to remove the unnecessary semicolons earlier:

> Please make another commit to fix the unnecessary introduction of semi-colons in the places I've highlighted.

@aorlov - could you take a look at this & ensure the semicolons have been removed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96883/new/

https://reviews.llvm.org/D96883