[PATCH] D101286: [LAA] Support pointer phis in loop by analyzing each incoming pointer.

Tue May 11 12:58:43 PDT 2021

efriedma added a comment.

In D101286#2751552 <https://reviews.llvm.org/D101286#2751552>, @fhahn wrote:

> In D101286#2749037 <https://reviews.llvm.org/D101286#2749037>, @efriedma wrote:
>
>> Do you need to check anything about the CFG before you just grab the PHI operand values?  For example, if there's a loop, you could have a PHI that refers to another PHI in the same basic block, and I suspect that would mess up the analysis.
>
> Thanks for the report. I think the issue here is slightly different: MemoryDepChecker does not collect the memory instructions for the translated pointers (the incoming values of the phi), but LoopDistribute tries to look them up. I put up D102266 <https://reviews.llvm.org/D102266> which should address this.

I wasn't commenting specifically in response to the crash report; just a general concern from reading the patch.  Are you confident the issue I'm describing isn't a problem?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101286/new/

https://reviews.llvm.org/D101286