[PATCH] D101704: [IR] Introduce the opaque pointer type

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 11 12:57:56 PDT 2021


dexonsmith accepted this revision.
dexonsmith added a comment.

In D101704#2751664 <https://reviews.llvm.org/D101704#2751664>, @aeubanks wrote:

> update test
> add to ReleaseNotes
> mention that opaque pointer types aren't ready for general use yet

LGTM!

In D101704#2749822 <https://reviews.llvm.org/D101704#2749822>, @pcc wrote:

> I think the most intuitive next step would be to get things working end-to-end with opaque pointers, starting with simple programs and going from there. As a side effect of that process we will no doubt cause some of the lit tests to start passing with opaque pointers -- as we do so, they can be converted incrementally to use opaque pointers.

Yeah, this approach sounds pretty reasonable.

I'm curious, have we exhausted what we can do statically? I wonder if refactoring to remove all callers of `PointerType::getElementType()` (and deleting the API) would be possible as an initial step. Might be simplify the problem in some ways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101704/new/

https://reviews.llvm.org/D101704



More information about the llvm-commits mailing list