[PATCH] D102252: [AMDGPU] Fix extra waitcnt being added with BUFFER_INVL2

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 11 11:27:38 PDT 2021


rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

LGTM with a nit: typo in comment.



================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:950
+  // FIXME: This should have already been handled by the memory legalizer.
+  // Removing this currently doesn't effect any lit tests, but we need to
+  // verify that nothing was relying on this. The number of buffer invalidates
----------------
Typo: affect.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102252/new/

https://reviews.llvm.org/D102252



More information about the llvm-commits mailing list