[PATCH] D102266: [LAA] Also handle pointer phis in ::addAccess.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 11 11:22:29 PDT 2021


fhahn created this revision.
fhahn added reviewers: Ayal, anemet, efriedma, Meinersbur.
Herald added a subscriber: hiraditya.
fhahn requested review of this revision.
Herald added a project: LLVM.

1ed7f8ede564 <https://reviews.llvm.org/rG1ed7f8ede564c3b11da4fdca30c36ccbff422576> added support for pointer phis in AccessAnalysis.

This patch also applies the same logic to MemoryDepChecker, because
otherwise we might crash, because we do not have IR instructions
associated with analyzed pointers. I think the same reasoning as
in 1ed7f8ede564 <https://reviews.llvm.org/rG1ed7f8ede564c3b11da4fdca30c36ccbff422576> should also apply in this case: we effectively treating
the memory operations with pointer phi operands as if they execute once
for each incoming value.

Fixes PR50296, PR50288.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102266

Files:
  llvm/include/llvm/Analysis/LoopAccessAnalysis.h
  llvm/lib/Analysis/LoopAccessAnalysis.cpp
  llvm/test/Transforms/LoopDistribute/pointer-phi-in-loop.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102266.344501.patch
Type: text/x-patch
Size: 10871 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210511/d805855f/attachment.bin>


More information about the llvm-commits mailing list