[PATCH] D102265: [lld][WebAssembly] Remove relocation target verification

[Sam Clegg via Phabricator via llvm-commits]

sbc100 created this revision.
Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, dschuff.
sbc100 requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

We have this extra step in wasm-ld that doesn't exist in other lld
backend which verifies the existing contents of the relocation targets.
This was originally intended as an extra form of double checking and an
aid to compiler developers.   However it has always been somewhat
contravertial and there have been suggestions in the past the we simply
remove it.

My motivation for removing it now is that its causing me a headache
when trying to fix an issue with negative addends.  In the case of
negative addends that final result can be wrapped/negative but this
checking code would require significant modifiation to be able to deal
with that case.  For example with some test cases I'm looking at I'm
seeing error like this:

  wasm-ld: warning: /usr/local/google/home/sbc/dev/wasm/llvm-build/tools/lld/test/wasm/Output/merge-string.s.tmp.o:(.rodata_relocs): unexpected existing value for R_WASM_MEMORY_ADDR_I32: existing=FFFFFFFA expected=FFFFFFFFFFFFFFFA

Rather than try to refactor calcExpectedValue to somehow return two
different types of results (32 and 64-bit) depending on the relocation
type, I think we can just remove this code.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102265

Files:
  lld/test/wasm/reloc-addend.s
  lld/wasm/InputChunks.cpp
  lld/wasm/InputFiles.cpp
  lld/wasm/InputFiles.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102265.344500.patch
Type: text/x-patch
Size: 7229 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210511/d26cccf8/attachment.bin>